Drop identifying stack based on name alone #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the logic to identify the egress stack only based on stack name. This was needed in the past for a migration to the non-static stack naming, but it's not desired if all egress stacks have ownership tags.
The motivation for removing is that if you run two clusters in a single AWS account region and there is an existing stack with the legacy name owned by one cluster, then the other cluster could delete the stack because it doesn't check ownership if it just checks the name.
This change assumes all egress stacks across the environment has proper clusterID/ownership tags.