Skip to content

Simplify flang preference helpers - #112

Merged
t-kalinowski merged 3 commits into
cache-compiler-configfrom
simplify-internal-helper-signatures
May 8, 2026
Merged

Simplify flang preference helpers#112
t-kalinowski merged 3 commits into
cache-compiler-configfrom
simplify-internal-helper-signatures

Conversation

@t-kalinowski

@t-kalinowski t-kalinowski commented May 8, 2026

Copy link
Copy Markdown
Owner

Draft stacked on #110.

Removes test-only which and system2 arguments from the flang probe/compiler helper signatures. Tests now mock Sys.which() and system2() directly.

Testing:

  • devtools::test()
  • rcmdcheck::rcmdcheck(error_on = "warning")

@codecov

codecov Bot commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.05%. Comparing base (fa49565) to head (b682b91).

Files with missing lines Patch % Lines
R/compiler.R 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           cache-compiler-config     #112      +/-   ##
=========================================================
- Coverage                  93.11%   93.05%   -0.07%     
=========================================================
  Files                         28       28              
  Lines                       6015     6006       -9     
=========================================================
- Hits                        5601     5589      -12     
- Misses                       414      417       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-kalinowski
t-kalinowski force-pushed the simplify-internal-helper-signatures branch from 9a16265 to b682b91 Compare May 8, 2026 03:32
@t-kalinowski
t-kalinowski marked this pull request as ready for review May 8, 2026 12:25
@t-kalinowski
t-kalinowski merged commit 86beab3 into cache-compiler-config May 8, 2026
6 of 8 checks passed
@t-kalinowski
t-kalinowski deleted the simplify-internal-helper-signatures branch May 8, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant