Fix scalar subsetting reductions and C-bridge dim handling - #65
Merged
Conversation
- Treat scalar arguments as non-reduced in max/min/sum/prod. - Fix `[` handling of `drop` and missing args; drop scalar subscripts and keep axis dims for logical scalars. - Guard assignment metadata capture. - Add tests for scalar reductions and tidy multiple-return test spacing.
- Keep names(c_dims) cleared before C glue to avoid named dims breaking bridge generation. - Preserve axis sizes when expanding logical/missing subscripts by using imap and per-axis dims. - Keep is_missing minimal. - Add regression tests for subsetting and reductions, including a 1x1 drop=FALSE case that fails without the dim-name strip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64
min(m[a, 1], m[b, 1])no longer emitminvalon scalars, avoiding the Fortran compile error shown in the report.[translation now tracks axis viaimapand carries correct dim info for logical/missing subscripts; C bridge generation strips dim names to preventdrop=FALSEfailures.