Add tanh() intrinsic and rev() handler - #90
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45c35d32b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (identical(x@value@mode, "logical") && logical_as_int(x@value)) { | ||
| out_val <- Variable("logical", x@value@dims) | ||
| return(Fortran( | ||
| glue("({base_name}(size({base_name}):1:-1) /= 0)"), |
There was a problem hiding this comment.
When the input is a logical vector passed via the bind(c) interface, NA values are stored as NA_LOGICAL (an integer sentinel). The rev() handler booleanizes the reversed storage with (/= 0), which turns any non‑zero value—including NA_LOGICAL—into .true.. That means rev(c(TRUE, NA, FALSE)) will return c(TRUE, TRUE, FALSE) instead of preserving NA. This regression is specific to the new rev() implementation for logical-as-int inputs; consider guarding NA or mapping with merge(1, 0, ...) plus an explicit NA check.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch. I fixed this by making rev() on bind(c) logicals reverse the underlying integer storage (0/1/NA) without booleanizing, so NA_LOGICAL is preserved on return (commit 00d5d28). To keep masks/compound expressions correct, I added booleanization at logical use sites for non-symbol expressions like rev(m) (ifelse, logical ops, pack/masks, reduction masks) and added stress tests covering these combinations (commit 93137e3). NEWS updated in 8de5547.
There was a problem hiding this comment.
Follow-up: added a regression test for nested rev() on external logicals with NA (commit efc779a) and fixed rev() hoisting to preserve bind(c) logical integer storage by propagating logical_as_int into the temporary (commit fa20990). This prevents NA_LOGICAL from being coerced to .true. in rev(rev(m)).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 92.76% 92.78% +0.01%
==========================================
Files 27 27
Lines 5734 5749 +15
==========================================
+ Hits 5319 5334 +15
Misses 415 415 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
\nrev() on bind(c) logical vectors returns integer storage to preserve NA.\nThis change threads booleanization through logical contexts (ifelse, pack,\nlogical ops, reduction masks) for non-symbol expressions and adds stress tests.
rev() on bind(c) logicals returns integer-backed expressions to preserve storage.\nMake as.integer() and which.max/min handle those expressions without emitting\nMERGE(..., mask=<integer>). Add regression tests.
|
Added regression test for integer-backed rev() logical expressions flowing into as.integer() and which.max/min(), and fixed both sites to handle bind(c) integer-backed logical expressions without emitting invalid MERGE(..., mask=) (commit dd0de4e). |
Avoid early return in symbol lowering so attr(,'r') and hoist rendering are applied consistently.
For scalar bind(c) logicals, avoid returning the booleanized (m/=0) form; return underlying integer storage so NA_LOGICAL is preserved and assignments stay integer->integer.
1 participant
This PR adds tanh() as a supported unary intrinsic and introduces an r2f handler for rev() (with tests).