Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VSCode ESLint Plugin unable to load correctly when using pnpm@10 #2090

Merged
merged 6 commits into from
Mar 28, 2025

Conversation

MaKTaiL
Copy link
Contributor

@MaKTaiL MaKTaiL commented Mar 27, 2025

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Starting with pnpm@10 two default options have been removed which caused ESLint plugin (and Prettier plugin in some cases) to fail to load correctly on VS Code.

See:

Fix: Added .npmrc file to extras folder with these two lines:

public-hoist-pattern[]=*eslint*
public-hoist-pattern[]=*prettier*

File will be copied when both ESLint and pnpm are detected.


Screenshots

image

💯

Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: 31fcdf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 7:24pm

@juliusmarminge juliusmarminge merged commit 5c657e2 into t3-oss:main Mar 28, 2025
274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants