feat(docker): add dual-runtime Docker workbench - #4875
Conversation
f509f80 to
cabe20c
Compare
|
已同步最新 I18n 兼容问题也已修复:Docker 文案改为 Autofill 可解析的对象字面量,当前 I18n Autofill 已通过。 本地验证:
当前主 CI 显示 |
t8y2
left a comment
There was a problem hiding this comment.
I found three blocking issues on b9f073f0474aea1563818028cdf1641f2ac76810.
-
crates/dbx-core/src/docker/compose.rs:28removes all existing project containers before every service has been parsed and validated. A later invalid service or Docker create/start failure therefore destroys the previous deployment and leaves a partial replacement. Please build and validate the complete execution plan before deletion, and add recovery or rollback behavior for failures during replacement. -
apps/desktop/src/lib/backend/http.ts:3513still buffers the complete image archive when no writable file handle is available, andsrc-tauri/src/commands/docker_cmd.rs:263still exposes the whole-imageVec<u8>command. Large images can exhaust backend or renderer memory. Please remove the full-buffer APIs and make every supported export path genuinely streaming, or reject runtimes where streaming persistence is unavailable. -
apps/desktop/src/components/docker/DockerWorkbench.vue:727parses Docker JSON stream errors but then checks only the original SSEevent.error. In Web mode, an HTTP 200 stream containingpull access deniedis overwritten by the final done event and shown as a successful pull. Please branch on the parsed progress result and add a regression test covering a split Docker error followed by stream completion.
|
已完成本轮阻塞问题修复并同步最新 修复内容:
本地验证:
I18n Autofill 已通过。 |
…r-workbench # Conflicts: # crates/dbx-core/src/sql_dialect/ddl_profile.rs
Summary
Review fixes
Verification
Closes #4874