Fix KBin and Volume4 compatibility with buildJsIcons#1469
Open
aliebald wants to merge 1 commit intotabler:mainfrom
Open
Fix KBin and Volume4 compatibility with buildJsIcons#1469aliebald wants to merge 1 commit intotabler:mainfrom
aliebald wants to merge 1 commit intotabler:mainfrom
Conversation
Nested svgs are not supported by build process
|
@aliebald is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
|
✅ All icons are valid! |
31 tasks
Author
|
@codecalm can you please take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1462 and fixes #1464
Adjusts volume-4 and brand-kbin to avoid nesting in group element, because buildJsIcons and buildNodes do not support nesting.
This does not change the icons visually or the stroke-width overriding behavior of brand-kbin.
References