fix(webfont): bring back all, outlined variant of webfont#1511
fix(webfont): bring back all, outlined variant of webfont#1511kakkokari-gtyih wants to merge 3 commits into
all, outlined variant of webfont#1511Conversation
|
@kakkokari-gtyih is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
| // Generate filled icons | ||
| const filledDirname = path.join(DIR, 'icons-filled'); | ||
| await processIcons(filledFiles, filledDirname, 'filled', DIR); | ||
| await generateFont('filled', 'filled', DIR); |
There was a problem hiding this comment.
Since the filled variant is required to generate the all variant, I've changed the code to build the filled first.
| "build:prepare": "mkdir -p icons-outlined dist && rm -fdr dist/*", | ||
| "build:webfont": "rm -fd dist/fonts/* && node .build/build-webfont.mjs", | ||
| "build:css": "pnpm run build:css:outline && pnpm run build:css:filled", | ||
| "build:css": "pnpm run build:css:outline && pnpm run build:css:filled && pnpm run build:css:all", |
There was a problem hiding this comment.
I've added the CSS generation for the all variant, as it was missing (but presented as an independent build script).
| "dependencies": { | ||
| "@tabler/icons": "workspace:", | ||
| "svg-path-commander": "^2.1.11", | ||
| "svgtofont": "^6.5.0" | ||
| }, |
There was a problem hiding this comment.
These dependencies are only needed at build time, so I moved them to devDependencies.
|
Updated to current main branch. Are there anything I can do to move this forward? Thanks! |
|
Also interested in seeing this restored. IMO, it was very odd to see this kind of breaking change in a minor version release, but it sounds like it was intentional. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
The diff is already on current main branch. Are there anything I can do to move this forward? Thanks! |
|
✅ All icons are valid! |
|
Fixed a problem where outline CSS wasn't generating, my bad. |
2 participants
Starting with v3.36.x, assets in the
tabler-icons-<weight>-outline.cssseries are no longer generated; instead, they are now generated astabler-icons-<weight>.css. As a result, there were no longer any variants that allowed the use of bothfilledandoutlinesimultaneously.This fix builds a new
allvariant after theoutlinebuild. In theallvariant, the-filledsuffix is appended to thefilledicon names (the same behavior as in versions prior to 3.35.0).Fix #1415
Fix #1452
Fix #1542