Skip to content

Custom build page by Gamebox #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mrmrs
Copy link
Member

@mrmrs mrmrs commented Apr 20, 2016

@gamebox - want to checkout these changes and tell me what you think?

I think this is a good MVP version of the customizer page.

A few wishes I have that if you can't get to no worries. Greatly appreciate the help getting it this far along.

  • Checkboxes with Labels instead of anchor tags
  • Compile button disappears when download link appears

If you don't have time or energy to hit those items I think this is ready to merge in - but wanted you to see the changes before I deployed. Let me know what you think. Cheers!

@gamebox
Copy link
Contributor

gamebox commented Apr 21, 2016

So this looks good to me @mrmrs I can hit both of those things this weekend. If you want to go ahead and merge as is, feel free, and I can submit a new PR. If you'd rather it ship all squeaky clean, hold off and I'll add to this PR. Thanks for covering up for my lack of design sensibilities ;-)

@gamebox
Copy link
Contributor

gamebox commented Apr 26, 2016

Just want to apologize for not getting that commit in this weekend. Baby on the way soon, and things are getting crazy. I'll set some time aside this week to rebase and get those changes done.

@mrmrs
Copy link
Member Author

mrmrs commented Apr 26, 2016

Please don't apologize. Your work is appreciated, no matter when you can get to it. Your contributions are not paid for and there is never any pressure to continue. We very much appreciate your efforts - especially with a baby on the way! I think this issue is important but it isn't important enough to stress over. At all.

Please please please understand you are under no obligation to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants