Increase /id polling timeout and remove stray copy-lyrics button - #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/iddetail page was showing a premature timeout-style message for slow generation/fetch cases and a floating "Copy lyrics" control could appear detached from the main view.Description
MAX_RETRIESfrom30to120insrc/components/smol/SmolResults.svelteso the detail fetch may retry up to ~4 minutes (120 * 2s)."Still generating in the background. Click retry to keep checking."insrc/components/smol/SmolResults.svelte.Copy lyricsbutton and its inline clipboard script fromsrc/pages/[id].astroso lyric copying is not presented independently of the main component state.Testing
pnpm -s checkwhich invoked Svelte/TypeScript diagnostics and reported pre-existing unrelated errors in otherlabs/and layout files; none of the failures point to the modifiedSmolResults.svelteor[id].astrochanges.Codex Task