Skip to content

Increase /id polling timeout and remove stray copy-lyrics button - #148

Merged
tacticalnoot merged 1 commit into
mainfrom
codex/fix-/id-page-loading-issue
May 16, 2026
Merged

Increase /id polling timeout and remove stray copy-lyrics button#148
tacticalnoot merged 1 commit into
mainfrom
codex/fix-/id-page-loading-issue

Conversation

@tacticalnoot

Copy link
Copy Markdown
Owner

Motivation

  • The /id detail page was showing a premature timeout-style message for slow generation/fetch cases and a floating "Copy lyrics" control could appear detached from the main view.
  • Improve user experience by giving the backend more time to finish generation and by removing the stray page-level copy control that could appear when the page was not fully loaded.

Description

  • Increased the polling window by changing MAX_RETRIES from 30 to 120 in src/components/smol/SmolResults.svelte so the detail fetch may retry up to ~4 minutes (120 * 2s).
  • Reworded the timeout message to "Still generating in the background. Click retry to keep checking." in src/components/smol/SmolResults.svelte.
  • Removed the global floating Copy lyrics button and its inline clipboard script from src/pages/[id].astro so lyric copying is not presented independently of the main component state.

Testing

  • Ran pnpm -s check which invoked Svelte/TypeScript diagnostics and reported pre-existing unrelated errors in other labs/ and layout files; none of the failures point to the modified SmolResults.svelte or [id].astro changes.
  • Verified the two modified files were updated and no new runtime logic was added beyond the polling limit and message change; manual inspection confirms the floating button and inline script were removed.

Codex Task

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying smol-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d4b2d2
Status:⚡️  Build in progress...

View logs

@tacticalnoot
tacticalnoot merged commit a78c06b into main May 16, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant