Skip to content

Conversation

@xdm67x
Copy link
Contributor

@xdm67x xdm67x commented Jul 23, 2025

Why?

Such as me, some users wants to be able to configure the Reader to match their needs. With the recent changes on the trim_text I wanted to find a way to satisfy everyone and also my needs.

How?

Add a From implementation to create a Deserializer using a custom NsReader.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.25%. Comparing base (254fbd2) to head (c98671c).
Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
src/de/mod.rs 15.78% 16 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   60.74%   55.25%   -5.50%     
==========================================
  Files          41       42       +1     
  Lines       16044    15353     -691     
==========================================
- Hits         9746     8483    -1263     
- Misses       6298     6870     +572     
Flag Coverage Δ
unittests 55.25% <15.78%> (-5.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun Mingun linked an issue Jul 23, 2025 that may be closed by this pull request
@Mingun Mingun merged commit a19d4a1 into tafia:master Jul 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using custom Reader for Deserializer

3 participants