[misc] SparseCG now respecting verbose value#8780
Open
3n3l wants to merge 2 commits intotaichi-dev:masterfrom
Open
[misc] SparseCG now respecting verbose value#87803n3l wants to merge 2 commits intotaichi-dev:masterfrom
3n3l wants to merge 2 commits intotaichi-dev:masterfrom
Conversation
Instead it always passed 'True' to make_float_cg_solver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this we always passed
Truetomake_float_cg_solver(...)instead of the
verbosevalue.Issue: #8707
Brief Summary
SparseCG was always printing information about convergence without a way to
turn off, this now respects the value of
verbosethat is passed in viati.init(...), as it should be.Walkthrough
We now pass the value of
verbosetomake_float_cg_solver(...)Closes #8707
Note
Ensures CG solver logging adheres to
ti.init(verbose=...).SparseCG.__init__now usesget_runtime().prog.config().verbosewhen creating_ti_core.make_cucg_solver,_ti_core.make_float_cg_solver, and_ti_core.make_double_cg_solverinstead of always passingTrue.Written by Cursor Bugbot for commit 4b6e2d1. This will update automatically on new commits. Configure here.