Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support primitive context in templates and components #782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: support primitive context in templates and components #782

wants to merge 2 commits into from

Conversation

splincode
Copy link
Member

@splincode splincode commented Mar 11, 2025 •
edited
Loading

Fixes #449

Before

image

@splincode splincode requested a review from a team as a code owner March 11, 2025 09:51
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team March 11, 2025 09:51
@splincode splincode force-pushed the splincode/fix/issues/449 branch from 4e84cf6 to 7f303de Compare March 11, 2025 09:57
waterplea
waterplea reviewed Mar 12, 2025
View reviewed changes
projects/ng-polymorpheus/src/utils/is-primitive.ts
@@ -0,0 +1,11 @@
export function isPrimitive(value: unknown): boolean {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a lot of checks. We only need to make sure it's not an object here, probably can be made easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waterplea updated

@splincode splincode force-pushed the splincode/fix/issues/449 branch from 33d7920 to 470d356 Compare March 13, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea left review comments

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

At least 1 approving review is required to merge this pull request.

Assignees

@splincode splincode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Primitive context in templates and components
2 participants
@splincode @waterplea