fix(host): cancel_task should also remove pending task #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
had a problem deploying
to
test-environment
GitHub Actions
Failure
smtmfft
reviewed
Nov 22, 2024
| } | ||
|
|
||
| pub async fn cancel_task(&mut self, key: ProofTaskDescriptor) -> HostResult<()> { | ||
| // Remove cancelling task from pending tasks |
Contributor
There was a problem hiding this comment.
no need here because cancel eventually make a signal to task process and break the loop there, so the pending will be cleared by complete signal there (correct me if I forget sth), anyway, this cancel is kind of tricky and better to refactory later on.
Contributor
Author
There was a problem hiding this comment.
Agree that cancel needs some more re-design and test coverage.
Contributor
Author
|
I'm not sure whether we should do clean pending tasks or not when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel_taskshould remove the target task from running and pending queue.