Skip to content

Comments

fix(raiko): update base fee validation logic in Shasta block processing#664

Merged
smtmfft merged 4 commits intomainfrom
fix-hoodi-shasta
Feb 5, 2026
Merged

fix(raiko): update base fee validation logic in Shasta block processing#664
smtmfft merged 4 commits intomainfrom
fix-hoodi-shasta

Conversation

@smtmfft
Copy link
Contributor

@smtmfft smtmfft commented Feb 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 5, 2026 14:23
@smtmfft smtmfft changed the title refactor: update base fee validation logic in Shasta block processing fix(raiko): update base fee validation logic in Shasta block processing Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the base fee validation logic for Shasta blocks by simplifying the condition that determines when to use the initial base fee. The change replaces a fork-based check with a simpler block-number-based check and adds additional logging for validation failures.

Changes:

  • Simplified the logic for determining when to use the initial base fee from a fork check to a simple block number comparison
  • Renamed parameter from is_first_shasta_proposal to use_init_base_fee for clarity
  • Added detailed warning logs when base fee validation fails in the initial block case

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/src/utils/shasta_rules.rs Renamed parameter and added warning log with details when initial base fee validation fails
lib/src/utils/shasta.rs Simplified the logic from checking if parent is in PACAYA fork to checking if parent block number is <= 1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smtmfft smtmfft added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 137cd59 Feb 5, 2026
12 of 13 checks passed
@smtmfft smtmfft deleted the fix-hoodi-shasta branch February 5, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants