fix(raiko): update base fee validation logic in Shasta block processing#664
Merged
fix(raiko): update base fee validation logic in Shasta block processing#664
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the base fee validation logic for Shasta blocks by simplifying the condition that determines when to use the initial base fee. The change replaces a fork-based check with a simpler block-number-based check and adds additional logging for validation failures.
Changes:
- Simplified the logic for determining when to use the initial base fee from a fork check to a simple block number comparison
- Renamed parameter from
is_first_shasta_proposaltouse_init_base_feefor clarity - Added detailed warning logs when base fee validation fails in the initial block case
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/src/utils/shasta_rules.rs | Renamed parameter and added warning log with details when initial base fee validation fails |
| lib/src/utils/shasta.rs | Simplified the logic from checking if parent is in PACAYA fork to checking if parent block number is <= 1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johntaiko
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.