fix(protocol): fix _getOperatorForEpoch in PreconfWhitelist.sol #19329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
|
I deployed this one, and its working so far. edit: nevermind, it changes the nextOperator mid epoch. I can try to deploy this one. If it doesnt work, we should just use the old |
…taikoxyz/taiko-mono into additional_whitelist_epoch_fix-
dantaik
requested review from
AnshuJalan,
linoscope,
adaki2004 and
davidtaikocha
linoscope
reviewed
Apr 24, 2025
Comment on lines
+224
to
+225
| // selectorEpochOffset must be big enough to ensure a non-zero beacon root is | ||
| // available and immutable. |
There was a problem hiding this comment.
Why does having big enough selectorEpochOffset ensure non-zero beacon root? In other words, isn't something like following enough?
Suggested change
| // selectorEpochOffset must be big enough to ensure a non-zero beacon root is | |
| // available and immutable. | |
| // selectorEpochOffset must be big enough to ensure that the beacon root is finalized and | |
| // cannot change due to reorg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #19327.
@cyberhorsey I think your fix won't work -- you make the timestamp (for which the beacon root is queried) bigger, which makes the return value less predictable as the random seed. I think we should make the value smaller so we query a older beacon root as the random seed.
Please test both your PR and mine to verify.