feat(protocol): add preconf slasher #19330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch) dependency (#19287)
…ns named (#19253) Co-authored-by: David <[email protected]> Co-authored-by: Keszey Dániel <[email protected]> Co-authored-by: adaki2004 <[email protected]> Co-authored-by: Gavin Yu <[email protected]>
Co-authored-by: Keszey Dániel <[email protected]>
Co-authored-by: Keszey Dániel <[email protected]>
adaki2004
reviewed
Apr 24, 2025
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
|
I feel I will also be including Preconf EOP violations in this same contract. I was inclining toward having a separate contract for EOPs, but now that I think about it, the preconfer would then need to opt into another contract just for EOP. This is inconvenient. |
adaki2004
reviewed
Apr 25, 2025
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
adaki2004
reviewed
Apr 25, 2025
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
dantaik
reviewed
Apr 26, 2025
packages/protocol/contracts/layer1/preconf/libs/LibPreconfConstants.sol
Outdated
Show resolved
Hide resolved
dantaik
approved these changes
May 22, 2025
linoscope
reviewed
May 22, 2025
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
dantaik
reviewed
May 23, 2025
packages/protocol/contracts/layer1/preconf/impl/PreconfSlasher.sol
Outdated
Show resolved
Hide resolved
dantaik
approved these changes
May 29, 2025
YoGhurt111
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers
Preconfirmation Structure,Preconfirmation Violations,Missing EOPandInvalid EOPsections of our LLD doc