Skip to content

fix(protocol): decouple preconf metadata existence from anchorBlockNumber #21763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dantaik wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −1
Open

fix(protocol): decouple preconf metadata existence from anchorBlockNumber #21763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/protocol/contracts/layer2/core/Anchor.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,14 @@ contract Anchor is EssentialContract {
}

/// @notice Metadata that will be required for slashing violations of permissionless preconfs.
/// @dev `stored` marks an existing entry so callers can distinguish a recorded block whose
/// `anchorBlockNumber` is 0 (a valid "skip checkpoint" value) from a block that was never
/// recorded. It packs into the same slot as the preceding `uint48` fields.
struct PreconfMetadata {
uint48 anchorBlockNumber;
uint48 submissionWindowEnd;
uint48 parentSubmissionWindowEnd;
bool stored;
bytes32 rawTxListHash;
bytes32 parentRawTxListHash;
}
Expand Down Expand Up @@ -205,7 +209,7 @@ contract Anchor is EssentialContract {
returns (PreconfMetadata memory)
{
PreconfMetadata memory preconfMetadata = _preconfMetadata[_blockNumber];
require(preconfMetadata.anchorBlockNumber != 0, InvalidBlockNumber());
require(preconfMetadata.stored, InvalidBlockNumber());
return preconfMetadata;
}

Expand Down Expand Up @@ -251,6 +255,7 @@ contract Anchor is EssentialContract {
anchorBlockNumber: _blockParams.anchorBlockNumber,
submissionWindowEnd: _proposalParams.submissionWindowEnd,
parentSubmissionWindowEnd: parentPreconfMetadata.submissionWindowEnd,
stored: true,
rawTxListHash: _blockParams.rawTxListHash,
parentRawTxListHash: parentPreconfMetadata.rawTxListHash
});
Expand Down
24 changes: 24 additions & 0 deletions packages/protocol/test/layer2/core/Anchor.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,30 @@ contract AnchorTest is Test {
assertEq(checkpointStore.getCheckpoint(staleBlockParams.anchorBlockNumber).blockNumber, 0);
}

function test_getPreconfMetadata_recordsBlockAnchoredAtZero() external {
// A block may legitimately be anchored with `anchorBlockNumber == 0` ("skip checkpoint").
// Its preconf metadata must still be retrievable so the slasher can validate faults; the
// `stored` marker distinguishes it from a block that was never recorded.
Anchor.ProposalParams memory proposalParams =
Anchor.ProposalParams({ submissionWindowEnd: 7 });
Anchor.BlockParams memory blockParams = _blockParams(0, 0x1234, 0x5678);

vm.roll(SHASTA_FORK_HEIGHT);
vm.prank(GOLDEN_TOUCH);
anchor.anchorV4(proposalParams, blockParams);

Anchor.PreconfMetadata memory meta = anchor.getPreconfMetadata(block.number);
assertTrue(meta.stored);
assertEq(meta.anchorBlockNumber, 0);
assertEq(meta.submissionWindowEnd, 7);
}

function test_getPreconfMetadata_RevertWhen_BlockNotRecorded() external {
vm.roll(SHASTA_FORK_HEIGHT);
vm.expectRevert(Anchor.InvalidBlockNumber.selector);
anchor.getPreconfMetadata(SHASTA_FORK_HEIGHT + 999);
}

// ---------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------
Expand Down
Loading