chore(deps): bump joi from 17.13.3 to 17.13.4#21787
Conversation
Bumps [joi](https://github.com/hapijs/joi) from 17.13.3 to 17.13.4. - [Commits](hapijs/joi@v17.13.3...v17.13.4) --- updated-dependencies: - dependency-name: joi dependency-version: 17.13.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c907872aa2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -207,7 +207,7 @@ importers: | |||
| version: https://codeload.github.com/dapphub/ds-test/tar.gz/e282159d5170298eb2455a6c05280ab5a73a4ef0 | |||
| forge-std: | |||
| specifier: github:foundry-rs/forge-std | |||
| version: https://codeload.github.com/foundry-rs/forge-std/tar.gz/3f999523613ab5454a5c4ae4abeaa8ea2ba7bcae | |||
| version: https://codeload.github.com/foundry-rs/forge-std/tar.gz/257559546b763ec5fa7371fb77fef9102db86446 | |||
There was a problem hiding this comment.
Avoid updating forge-std in the Joi lockfile bump
For packages/nfts, forge-std/ is remapped to node_modules/forge-std/ in packages/nfts/foundry.toml, and the NFT CI installs this lockfile before running pnpm compile and pnpm test in .github/workflows/nfts.yml. This line moves the untagged GitHub dependency from the previous locked forge-std 1.11.0 commit (3f999...) to the current main commit/version 1.16.1 (257559...), so a Joi-only lockfile update silently changes the Solidity test/script library used by NFT builds. Keep the previous lock entry or pin the package.json specifier unless this contract dependency update is intentional and reviewed.
Useful? React with 👍 / 👎.
Bumps joi from 17.13.3 to 17.13.4.
Commits
3d3ab7617.13.44bcdf36Merge pull request #3123 from hapijs/chore/backport-311397bd51dchore: backport #3113 to v17Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.