feat(taiko-client): add local proposal metadata API#21791
Conversation
🐋 DeepSeek Code Review🔴 Critical IssuesNo critical issues found. 🟡 Warnings
🔵 Suggestions
🟢 What Looks Good
Automatically triggered on PR update • model: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5411830c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary
GET /internal/shasta/proposals/{proposal_id}with reconstructed proposal,hashProposal, and L1 event coordinatesproposalApi.enabled/proposalApi.addrflags and reject non-loopback bindsTests
go test ./packages/taiko-client/pkg/proposalapi ./packages/taiko-client/cmd/flagsgo test ./packages/taiko-client/driver -run 'TestNewConfigFromCliContextRejectsRemoteProposalAPIAddress|TestResolveEndpointsPrefersWSOverHTTP'\n-git diff --check\n\n## Notes\n- Fullgo test ./packages/taiko-client/driverwas not usable in this local environment: the existing driver suite expects devnet env vars/JWT and fails duringinternal/testutilssetup with empty env parsing / invalid JWT length before reaching these changes.\n-golangci-lintis not installed in this environment (command not found).