feat: add support for separate runtime config in json & yaml formats#3221
Merged
tusharmath merged 2 commits intomainfrom Dec 13, 2024
Merged
feat: add support for separate runtime config in json & yaml formats#3221tusharmath merged 2 commits intomainfrom
tusharmath merged 2 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 86.46% 86.39% -0.08%
==========================================
Files 282 282
Lines 28705 28724 +19
==========================================
- Hits 24820 24816 -4
- Misses 3885 3908 +23 ☔ View full report in Codecov by Sentry. |
tusharmath
reviewed
Dec 13, 2024
3164cf4 to
0c5e54e
Compare
tusharmath
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow to specify separate runtime config as input in the json/yaml formats.
To test it out:
At the same time it's still possible to define everything in the graphql file
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>