Skip to content

feat: add support for separate runtime config in json & yaml formats#3221

Merged
tusharmath merged 2 commits intomainfrom
refactor/runtime-config
Dec 13, 2024
Merged

feat: add support for separate runtime config in json & yaml formats#3221
tusharmath merged 2 commits intomainfrom
refactor/runtime-config

Conversation

@meskill
Copy link
Contributor

@meskill meskill commented Dec 12, 2024

Summary:
Allow to specify separate runtime config as input in the json/yaml formats.

To test it out:

cargo run -- start ./examples/jsonplaceholder.yaml

At the same time it's still possible to define everything in the graphql file

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Dec 12, 2024
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 26.12613% with 82 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (316254c) to head (0c5e54e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/tc/init.rs 0.00% 47 Missing ⚠️
src/core/config/config.rs 27.90% 31 Missing ⚠️
src/cli/generator/source.rs 75.00% 2 Missing ⚠️
src/core/config/source.rs 85.71% 1 Missing ⚠️
tailcall-typedefs/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
- Coverage   86.46%   86.39%   -0.08%     
==========================================
  Files         282      282              
  Lines       28705    28724      +19     
==========================================
- Hits        24820    24816       -4     
- Misses       3885     3908      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title feat: add support for separate runtime config in json/yaml formats feat: add support for separate runtime config in json & yaml formats Dec 13, 2024
@tusharmath tusharmath force-pushed the refactor/runtime-config branch from 3164cf4 to 0c5e54e Compare December 13, 2024 22:41
@tusharmath tusharmath enabled auto-merge (squash) December 13, 2024 22:41
@tusharmath tusharmath merged commit 76fc565 into main Dec 13, 2024
27 checks passed
@tusharmath tusharmath deleted the refactor/runtime-config branch December 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants