cmd/go/internal/test: add opt-in file hashing instead of modtime for test caching (w/ git) #151
+170
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
approved these changes
Jan 28, 2026
| } | ||
| } | ||
| } else if info.Mode().IsRegular() { | ||
| } else if info.Mode().IsRegular() && !useGitHash() { |
Member
There was a problem hiding this comment.
Should we add the same logic in cmd/go/internal/modindex/read.go? That does something very similar and references this code.
Member
Author
There was a problem hiding this comment.
per chat, ignoring for now, as we use https://github.com/tailscale/gomodfs/ and it doesn't affect us at least. But we should do that before upstreaming this.
Member
Author
There was a problem hiding this comment.
(as gomodfs always has predictable modtimes)
tomhjp
reviewed
Jan 28, 2026
bradfitz
force-pushed
the
bradfitz/git_hash_25_branch
branch
2 times, most recently
from
4fb143b to
95aa413
Compare
…test caching (w/ git) Updates golang#58571 Updates #150 (cherry picked from commit 64af022)
bradfitz
force-pushed
the
bradfitz/git_hash_25_branch
branch
from
95aa413 to
485c689
Compare
tomhjp
reviewed
Jan 28, 2026
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Jan 28, 2026
This pulls in tailscale/go#151, which we want to begin experimenting with. Updates tailscale/go#150 Change-Id: I69aa2631ecf36356430969f423ea3943643a144a Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Jan 28, 2026
This pulls in tailscale/go#151, which we want to begin experimenting with. Updates tailscale/go#150 Change-Id: I69aa2631ecf36356430969f423ea3943643a144a Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Jan 28, 2026
This pulls in tailscale/go#151, which we want to begin experimenting with. Updates tailscale/go#150 Change-Id: I69aa2631ecf36356430969f423ea3943643a144a Signed-off-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates golang#58571
Updates #150
(cherry picked from commit 64af022)