cmd/go/internal/test: add opt-in file hashing instead of modtime for test caching (w/ git) #153
+188
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test caching (w/ git) Updates golang#58571 Updates #150 (cherry picked from commit 64af022)
bradfitz
force-pushed
the
bradfitz/25_githash
branch
2 times, most recently
from
c0dcbd1 to
4b58c16
Compare
Member
Author
bradfitz
commented
Jan 28, 2026
Comment on lines
+18
to
+26
| // GitHash is a git hash in hex form. | ||
| // | ||
| // It's usually a SHA-1 hash, but could be SHA-256 depending on the git | ||
| // configuration. | ||
| type GitHash string | ||
|
|
||
| // Enabled is whether git hash lookups are enabled via the CMD_GO_USE_GIT_HASH | ||
| // environment variable. | ||
| var Enabled bool |
src/cmd/go/internal/modindex/read.go
Outdated
| return h.Sum(), nil | ||
| } | ||
|
|
||
| func modTimeOrHash(info fs.FileInfo) any { |
Member
Author
There was a problem hiding this comment.
I can probably unify these
…test caching (w/ git) Updates golang#58571 Updates #150 (cherry picked from commit 64af022)
bradfitz
force-pushed
the
bradfitz/25_githash
branch
from
4b58c16 to
560747f
Compare
bradfitz
force-pushed
the
tailscale.go1.25
branch
from
485c689 to
799b253
Compare
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Jan 28, 2026
This pulls in tailscale/go#153, which we want to begin experimenting with. Updates tailscale/go#150 Change-Id: Id3e03558ee69e74361431650530e8227dfdef978 Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Jan 28, 2026
This pulls in tailscale/go#153, which we want to begin experimenting with. Updates tailscale/go#150 Change-Id: Id3e03558ee69e74361431650530e8227dfdef978 Signed-off-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates golang#58571
Updates #150