ts_tunnel: add helpers for endpoint testing, session rotation tests#284
Open
danderson wants to merge 1 commit into
Open
ts_tunnel: add helpers for endpoint testing, session rotation tests#284danderson wants to merge 1 commit into
danderson wants to merge 1 commit into
Conversation
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 16, 2026 17:09
b5b8f4f to
da94673
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 16, 2026 23:18
2d74994 to
e582217
Compare
danderson
changed the title
danderson
marked this pull request as ready for review
July 16, 2026 23:23
Member
Author
|
CI is currently broken due to github having an API outage, but |
nrc
approved these changes
Jul 17, 2026
nrc
left a comment
nrc
left a comment
Contributor
There was a problem hiding this comment.
Looks good, a couple of optional suggestions for removing more boilerplate.
danderson
force-pushed
the
push-vklkwnswztqz
branch
from
July 22, 2026 17:05
db040d4 to
3b9569b
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 22, 2026 17:34
e582217 to
e6966a6
Compare
danderson
force-pushed
the
push-vklkwnswztqz
branch
from
July 22, 2026 18:42
3b9569b to
a4de20c
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 22, 2026 18:44
e6966a6 to
2511eb5
Compare
danderson
force-pushed
the
push-vklkwnswztqz
branch
from
July 23, 2026 19:41
a4de20c to
30a457e
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 23, 2026 19:41
2511eb5 to
6203967
Compare
danderson
force-pushed
the
push-vklkwnswztqz
branch
from
July 24, 2026 19:45
30a457e to
ce31ede
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 24, 2026 19:45
6203967 to
8fb0177
Compare
Updates #283 Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I4fef3c7306905957932220aca8bcab1f6a6a6964
danderson
force-pushed
the
push-vklkwnswztqz
branch
from
July 24, 2026 19:53
ce31ede to
a120aab
Compare
danderson
force-pushed
the
push-rpnxoxqnpsrp
branch
from
July 24, 2026 19:53
8fb0177 to
416bace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #283
This started out as the regression tests for #286, but the endpoint-level tests were hard enough to write that I went down a rabbithole of writing helpers to make the tests convey their intent a bit more clearly. This PR contains those helpers, the refactor of the existing endpoint test to use them, and two more tests to test that session rotation works per #283.