fix: prevent Svelte files from breaking when there are duplicate classes #359
+23
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v0.6.11, Svelte files still break after saving a file that contains duplicate classes in template strings.
This seems to be because of a bug where there are certain times
transformSvelte
results in calls tosortClasses
that don't passremoveDuplicates
at all, butsortClasses
defaults it to true, resulting in the plugin attempting to remove duplicates even though this is not supported yet in Svelte.Now, we pass
removeDuplicates
in all cases. In the case of string literals, this results in the classes being sorted with the duplicates remaining (without breaking your project). Getting the functionality of removing duplicates removed in string literals requires more work.However, it seems that removing duplicates in the normal "text" (non-literal) case works totally fine in Svelte, so I decided to enable removing duplicates in that case. Added some new tests with duplicates in the 3 different cases that all pass.
Before
Thanks to @onsclom for helping on this!