Bump minimum version requirements #1297
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
bump-deps
branch
2 times, most recently
from
5452770 to
32a5490
Compare
This will set us up for more direct, language-service specific testing. This is very much a work in progress but the ultimate goal is for the majority of language server tests to be able to run against both the language service _and_ language server
Protocol v3.17 added support for pull-model diagnostics which are modeled as a “report” that is either a full set of diagnostics for a document (and related documents) or “unchanged” We can convert these to the push model by pulling the diagnostics like we were doing before and inspecting the report before pushing diagnostics to the client
Most relevant requests are document related in some manner and this will serve a few purposes: - It centralizes logic common to all providers - It can help simplify the implementation of providers - It reduces duplication by moving common actions into the document creation layer (e.g. loading settings)
This uses the new virtual document abstraction to simplify the implementation of the provider. Now it operates only on things it cares about: - utility class names - CSS helper functions
It makes types for Vitest work better
VSCode 1.90+ and Node v20.9+
thecrypticace
force-pushed
the
bump-deps
branch
from
32a5490 to
9d023a5
Compare
thecrypticace
changed the base branch from
main
to
feat/refactor-language-service-usage
thecrypticace
force-pushed
the
feat/refactor-language-service-usage
branch
from
007b8e2 to
555b78d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm bumping the minimum Node.js and VSCode versions for the language server and the VSCode extension since Node v18 hits end-of-life on April 27th, 2025. The earliest electron version with Node v20 support is 29 which is already unsupported. I'd prefer to bump to a vscode version with a supported version of Electron but that is v1.98 which was only released 2 months ago.
As such I'm planning to bump the minimum versions for IntelliSense to these:
I'm also using this as an opportunity to bump several dependencies to ensure the project stays up to date.
This will require a 0.x+2 version bump of all affected packages as will #1271 so it is necessary to ship these two PRs together in the same release.
The currently planned release date for this change is mid June 2025