refactor: remove cypress and fix storybook#1040
Merged
Merged
Conversation
|
New Issues (13)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
lucasoares
commented
Jun 11, 2025
lucasoares
left a comment
Member
Author
There was a problem hiding this comment.
WIP: must test storybook github page creation, since I changed few things on storybook!
… toolbar visibility
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the project by removing Cypress testing files and updating Storybook configurations and workflows to improve the development experience.
- Removed all Cypress test files and the Cypress configuration.
- Updated Storybook preview, manager, and main configurations for improved integration and deployment.
- Added new Husky hooks and GitHub workflows for linting, testing, and deployment.
Reviewed Changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cypress/component/*.cy.tsx | Removed Cypress component tests |
| cypress.config.ts | Removed Cypress configuration file |
| .storybook/preview.js | Updated custom elements initialization with window parameter |
| .storybook/preview-head.html | Updated script paths for Storybook integration |
| .storybook/manager.js | Adjusted Storybook manager settings with added layout options |
| .storybook/main.js | Updated configuration for Storybook, including staticDirs and managerWebpack |
| .husky/* | Added Husky hooks for linting, testing, and commit message validation |
| .github/workflows/* | Added new workflows for testing, publishing, and PR Storybook previews |
| .github/copilot-instructions.md | Updated project instructions for contributors |
| .eslintrc.js and .eslintignore | Updated ESLint configuration to reflect current project structure |
| .cz-config.js | Added a new commit type 'ci' for conventional commits |
Comments suppressed due to low confidence (2)
.storybook/manager.js:10
- The use of 'undefined' as a string for selectedPanel may be confusing. Consider using null or omitting the property if no default panel should be selected.
selectedPanel: 'undefined',
.storybook/preview-head.html:2
- Ensure that the updated script paths for Storybook are correct and resolve as expected in the new project structure.
<script type="module" src="./blip-ds/blip-ds.esm.js"></script>
godrien
approved these changes
Jun 11, 2025
diogobarrel
approved these changes
Jun 11, 2025
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This pull request introduces several important changes across multiple themes, including workflow enhancements, updates to project configuration, improvements to Storybook integration, and removal of Cypress testing files. Below is a summary of the most significant changes:
AFTER THIS PR, ANYONE CAN JUST CLONE THE PROJECT, RUN
npm iAND THEN RUNnpm run devAND IT WILL JUST WORK!Workflow Enhancements
.github/workflows/test.yml) and Storybook preview (.github/workflows/pr-storybook.yml) to automate testing and preview generation for pull requests. [1] [2]Project Configuration Updates
cias a new commit type in.cz-config.jsfor conventional commits..eslintrc.jsto automatically detect the React version for linting.Storybook Integration Improvements
Removal of Cypress Testing Files
cypress.config.ts) and component tests (cypress/component/Input.cy.tsx,cypress/component/InputChips.cy.tsx) as part of a cleanup effort. [1] [2] [3]Husky Integration for Commit Validation
.husky/pre-commit), pre-push (.husky/pre-push), and commit message validation (.husky/commit-msg) to enforce code quality and conventional commit standards. [1] [2] [3]ghookssince it is a outdated project and it is no longer updated