fix(input): prevent false validation errors during browser autofill (#884878)#1072
Draft
victorguimaraes2153 wants to merge 3 commits into
Draft
fix(input): prevent false validation errors during browser autofill (#884878)#1072victorguimaraes2153 wants to merge 3 commits into
victorguimaraes2153 wants to merge 3 commits into
Conversation
|
|
New Issues (46)Checkmarx found the following issues in this Pull Request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix: Prevent validation errors on browser autofill for input components
🐛 Problem
The
bds-inputandbds-input-passwordcomponents were incorrectly displaying validation error messages when the browser automatically filled fields using saved credentials. This occurred because:emailValidation()method was executed even on empty fieldsnumberValidation()method validated fields containing only whitespace✅ Solution
bds-inputComponent:Cannot read properties of undefined (reading 'valid')error incheckValidity()methodemailValidation()andnumberValidation()to only validate when field has contentonFocuseventbds-input-passwordComponent:onInput,onFocusandonBlureventscomponentDidUpdateto maintain synchronization between value and nativeInputkeyPressWrapperto properly handle Backspace and Delete keys🔗 Related Issue
Fixes #884878
🚀 How to Test
bds-input(email type) andbds-input-passwordfields