fix: Add data URL support to bds-image component#1098
Draft
Copilot wants to merge 5 commits into
Draft
Conversation
|
Co-authored-by: lucasmiqueias <11753940+lucasmiqueias@users.noreply.github.com>
Co-authored-by: lucasmiqueias <11753940+lucasmiqueias@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
fix: Add data URL support to bds-image component
Oct 20, 2025
bds-image failing to load Data URLs…ta-url-loading-issue
Contributor
|
@copilot verifique os seguintes pontos:
|
Co-authored-by: TarsysFonseca <3694626+TarsysFonseca@users.noreply.github.com>
Contributor
Author
I've reviewed the points you raised. Here's the status: Already implemented in the component:
Addressed in this update (ea42b68):
Future enhancements (beyond scope of this PR):
This PR's scope was specifically to fix data URL loading. The enhancement suggestions listed would benefit from dedicated planning and implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix bds-image to support data URLs ✅
Summary
The
bds-imagecomponent now successfully loads data URLs without attempting to fetch them. This enables embedding images directly (e.g., icons or dynamically generated thumbnails) without hosting files.Changes Made
Core Implementation (
image.tsx)data:) before usingfetch()currentSrcwithout fetchingTests
Storybook Documentation
bds-grid,bds-typo,bds-paper) instead of raw HTMLScreenshot
Verification Summary
Response to Review Comments
Regarding the enhancement suggestions:
bds-skeleton)The following are future enhancement suggestions beyond the scope of this PR:
These would require significant architectural changes and should be tracked as separate issues.
Original prompt
Fixes #1097
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.