Prevent unfulfilled promises on sendCommand method

[VictorBalbo]

Prevent keeping unfulfilled promises on memory because of SendCommand method.

[ceifa]

To prevent a memory leak caused by an error in this function execution, you can design it in that way:

() => {
    try {
        // logic here
    } catch (err) {
        return reject(...);
    } finally {
        delete this._commandResolves[command.id];
    }
}

[VictorBalbo]

We actually need a race of 2 promises here, because the command must fail if there was no response before the timeout

[ceifa]

I didn't question that. I'm talking about the arrow function you pass on the first promise.

[samwx]

The try/catch block is a good way to prevent unhandled errors. By the way, it might help us to handle exceptions better at BLiP Portal

[ceifa]

Why do you need to check it?

[VictorBalbo]

I just added the bracket, but this if is used to guarantee the promise will only be reject for commands with timeout

[ceifa]

That if statement seems to be impossible to be true.

[ceifa]

But anyway, I don't think that returning a string can be a good thing, think that consumers are expecting a specific type, in the case a lime envelope, returning a different type can cause problems. Miss you, typescript :(