enable query parameter passing #35
Conversation
| notebook_url = url_path_join('notebooks', url_escape(path)) | ||
| if query: | ||
| notebook_url = notebook_url + query | ||
| notebookapp.launch_new_instance(default_url=notebook_url, |
There was a problem hiding this comment.
default_url will, for the lifetime of the notebook server it starts, redirect requests for / to default_url. I'd rather not change the behaviour of the notebook server like that just to get it to open the right page once.
There was a problem hiding this comment.
I understand, this is behaviour which affects a number of aspects.
I will investigate a plausible alternative
|
Hi @takluyver I have altered the approach, such that the process to open a new notebook can be held in a thread whilst a new server is created, if required this has the advantage that the logic for opening a notebook is encapsulated, rather than being different for a new server or an already open one however, there are aspects that I think could be neater, for example, there is an arbitrary time to wait, which seems a bit inelegant if you like the approach in principle, I can look to tidy up the implementation; any suggestions on this are most welcome thank you |
Hi @takluyver
Great tool, many thanks.
I have a proposed adaption, which enable query parameters to be passed to the notebook to be opened.
This enables a number of use cases to be addressed, including
opening the notebook in dashboard view
I hope this seems like a useful feature. Is the implementation up to scratch?
cheers
mark