-
-
Notifications
You must be signed in to change notification settings - Fork 94
feat: add kubernetes deployment configuration using helm #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcstryker
wants to merge
12
commits into
tale:main
Choose a base branch
from
jcstryker:feat/add-helm-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jcstryker <[email protected]>
Open
For reference I added some stuff on top of @antoniolago's repo here I only was trying to get things working, use my changes however you would like or not at all :) |
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
This commit removes the unused PersistentVolumeClaim templates for headplane and headscale components. The templates were left in place but contained only a TODO comment, indicating they were not yet implemented. Removing them cleans up the codebase and prevents confusion about their intended purpose. The pvc templates were previously defined in the kubernetes/headplane/templates/headplane/pvc.yaml and kubernetes/headplane/templates/headscale/pvc.yaml files but were not actually needed for the current implementation. This change reduces code clutter and improves maintainability by removing dead code. Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
…scale This commit introduces the missing PersistentVolumeClaim templates for both headplane and headscale components. The changes implement the full PVC specification with support for: - Custom annotations and labels - Configurable access modes - Storage requests - Storage class configuration The templates follow the existing pattern used in the helm chart and are conditionally enabled based on the persistence configuration values. This provides the necessary storage persistence for both services when enabled. The implementation includes proper templating with Helm syntax to ensure compatibility with the chart's configuration system. Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
@tale this should be ready for review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #55
Alternative Helm chart to the chart provided here https://github.com/nbcloudio/headplane-chart - I have some concerns around best practices and security - feeling it best to start from scratch to also resolve licensing concerns.
This is provided to this project under the MIT licence.
Thank you to
@antoniolago for doing some fantastic work updating that chart from nbcloudio
@definitelynobody for some further enhancements to the nbcloudio chart - I did not adapt anything directly for this first version of the chart but happy to take a look and help bring some of those features in the future
I have tested OIDC Login, Persistence, Admin Login, Database-backed ACLs - I am successfully serving 5-10 devices covering common use cases like exit nodes with this chart in my Homelab.
Notably missing is the tailscale relay feature from the @nbcloudio/@antoniolago/@definitelynobody version of the chart.
I am happy to look into adding that feature in a followup PR once I have time to understand what it does, or someone else can take that enhancement.
example
values.yaml
used for testingFollow Up PR ideas: