Storage engine experiment of LSM-tree. #443
Conversation
Connor1996
left a comment
Connor1996
left a comment
There was a problem hiding this comment.
As a course, please clean the implementation and give a tutorial
|
The implementation has been cleaned up and a tutorial has been added to doc/tinydb. |
|
go-ycsb has been removed and added as a submodule |
| @@ -0,0 +1,3 @@ | |||
| [submodule "go-ycsb"] | |||
| path = go-ycsb | |||
| url = [email protected]:QingyangZ/go-ycsb.git | |||
There was a problem hiding this comment.
You can file another PR to https://github.com/pingcap/go-ycsb?
| replace github.com/jmhodges/levigo => ./levigo | ||
|
|
||
| replace github.com/tecbot/gorocksdb => ./gorocksdb |
There was a problem hiding this comment.
What are the changes? Just like the go-ycsb part, we need the diff to review them.
There was a problem hiding this comment.
I've received feedback that the amount of code including go-ycsb is too large, so I've used a submodule instead.
There was a problem hiding this comment.
But I was commenting at levigo and gorocksdb, not go-ycsb. They should be submitted the same way as go-ycsb.
There was a problem hiding this comment.
Sorry, I misunderstood your meaning earilier. The original gorocksdb has been slightly modified to fit the version of Rocksdb and levigo is not modified.
doc/tinydb/Home.md
Outdated
| @@ -0,0 +1,69 @@ | |||
| # Welcome to the TinyDB! | |||
| TinyDB is a course designed to help you quickly familiarize yourself with the underlying storage engine of [TiKV Project](https://github.com/tikv/tikv). | |||
There was a problem hiding this comment.
How about regarding TinyDB as one lab of TinyKV? and I think TinyEngine would be less ambiguous.
There was a problem hiding this comment.
Thanks for your suggestion. I agree TinyEngine is more appropriate. I will modify the description in the next submission.
|
Good work! Hope to see it soon. |
4 participants
TinyDB is a course designed to help students quickly familiarize themselves with LSM-tree. Submitted by ADSL of USTC.