Skip to content

Generalize row-key-decoding #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whichxjy wants to merge 2 commits into
base: course
Choose a base branch
from
Open

Generalize row-key-decoding #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e5425
Generalize row-key-decoding
whichxjy Sep 2, 2020
f91453d
Remove a blank line
whichxjy Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tablecodec/tablecodec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ func DecodeTableID(key kv.Key) int64 {

// DecodeRowKey decodes the key and gets the handle.
func DecodeRowKey(key kv.Key) (int64, error) {
if len(key) != RecordRowKeyLen || !hasTablePrefix(key) || !hasRecordPrefixSep(key[prefixLen-2:]) {
if len(key) != RecordRowKeyLen || !hasTablePrefix(key) || !hasRecordPrefixSep(key[prefixLen-recordPrefixSepLength:]) {
return 0, errInvalidKey.GenWithStack("invalid key - %q", key)
}
u := binary.BigEndian.Uint64(key[prefixLen:])
Expand Down Expand Up @@ -445,7 +445,6 @@ func DecodeIndexHandle(key, value []byte, colsLen int, pkTp *types.FieldType) (i
return 0, errors.Trace(err)
}
return d.GetInt64(), nil

} else if len(value) >= 8 {
return DecodeIndexValueAsHandle(value)
}
Expand Down