Remove blank line from .pronto_spell.pws that segfaults aspell#28
Open
Vitalini wants to merge 1 commit into
Open
Remove blank line from .pronto_spell.pws that segfaults aspell#28Vitalini wants to merge 1 commit into
Vitalini wants to merge 1 commit into
Conversation
A blank line right after the personal_ws header (introduced in cd8d62d) makes aspell segfault on the first speller_check call, so every Pronto run that reaches spell checking dies with: ffi-aspell-1.1.0/lib/ffi/aspell/speller.rb:219: [BUG] Segmentation fault This has been failing the Pronto job on all non-Dependabot PRs in talkable-integration (and any other repo using this shared word list) since late April. Reproduced locally: with the blank line aspell crashes; with it removed the word list loads and checks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since late April, the Pronto job fails on every non-Dependabot PR in
talkable-integration(and any other repo that consumesshared/.pronto_spell.pws) with a hard Ruby crash:Example failing run: https://github.com/talkable/talkable-integration/actions/runs/28809252490/job/85598894544?pr=846
Dependabot PRs pass only because their diffs contain nothing for the spell checker to inspect, so the speller is never exercised.
Root cause
Commit cd8d62d ("Update spellcheck words", Apr 23) introduced a blank line right after the
personal_ws-1.1 en 0header. aspell chokes on the empty entry in the personal word list and segfaults on the very firstaspell_speller_checkcall.Reproduced locally (macOS arm64, aspell 0.60.8.2, ffi-aspell 1.1.0, Ruby 4.0.3) — matches CI (ubuntu 24.04 arm64, Ruby 4.0.2):
Speller#correct?callgrecaptcha,gusieva, …) are recognized as correctFix
Delete the blank line. One-line change, no words added or removed.