Add Configs for Monitoring #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces a structured monitoring configuration for the allocator service, encompassing resource usage thresholds, budget limits, and CloudTrail logging settings. The new configuration enables centralized management of monitoring and alerting parameters.
- Adds four new dataclasses (
ThresholdsConfig,BudgetConfig,CloudTrailConfig,MonitoringConfig) to define monitoring-related settings - Integrates monitoring configuration into the top-level
Configdataclass - Establishes default values for resource usage limits and monitoring parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/allocator/src/lablink_allocator_service/conf/structured_config.py
Show resolved
Hide resolved
packages/allocator/src/lablink_allocator_service/conf/structured_config.py
Outdated
Show resolved
Hide resolved
packages/allocator/src/lablink_allocator_service/conf/structured_config.py
Outdated
Show resolved
Hide resolved
packages/allocator/src/lablink_allocator_service/conf/structured_config.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new structured configuration for monitoring, alerting, and resource usage thresholds in the allocator service. The main changes add new dataclasses to encapsulate monitoring-related settings, such as thresholds for resource usage, budget limits, and CloudTrail logging, and integrate them into the main configuration.
Monitoring and resource usage configuration:
MonitoringConfigdataclass to group monitoring settings, including enabling/disabling monitoring, alert email, resource usage thresholds, budget, and CloudTrail logging.ThresholdsConfigto define limits for instance creation/termination, IAM role creation, security group changes, and unauthorized API calls within specified time windows.BudgetConfigfor monthly budget limits and alert thresholds, andCloudTrailConfigfor CloudTrail log retention configuration.Integration into main configuration:
MonitoringConfiginto the top-levelConfigdataclass, making monitoring and alerting settings available throughout the service configuration.