-
Notifications
You must be signed in to change notification settings - Fork 848
Add some common talon python functions to python common functions #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add some common talon python functions to python common functions #2081
Conversation
nriley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from the community backlog session:
- Use actions instead of corresponding methods where possible
- For actions, enable
user.talon_populate_listsby default for non-dragon and fix the documentation in the file that declares the actions that reference this.
I reorganized the talon common file. The lists are now populated by default with conformer. Actions cannot be used for settings.get without beta, so I did not make that change. We might want to do some performance testing with the populate lists tag before merge, but it works fine on my machine. I decided to address the action command adding an unnecessary new line by only using the selected text as an argument with a wrap command variant. |
|
From the community backlog session — this is ready to merge, but we want to make sure it does not adversely affect performance on slower computers and the release version of Talon. This is likely to cause a delay on grammar compilation which typically occurs when you issue your first voice command in a new context. |
The goal is to make things like "settings.get()" and "actions.clip.text()" a little easier.