-
Notifications
You must be signed in to change notification settings - Fork 847
Added system actions: exit menu etc. #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Implemented them for Windows. - Transferred one action for Linux from an existing .talon file.
for more information, see https://pre-commit.ci
| def system_lock(): | ||
| # Adapt key configuration as needed. | ||
| actions.key("super-shift-x") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very problematic: it moves a setting that is neither a default nor really a widely adopted convention to a file that has nothing to do with i3wm. Thus, this would become very hard to discover. I am not even entirely convinced that there is any configuration for these commands that would work reliably across desktop environments. I'm not aware of any general configuration for the major environments like Gnome and KDE in community. Of course, the major desktop environments have recently dropped support for X11 and, by extension, Talon. But that's a different can of worms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a setting that is neither a default nor really a widely adopted convention
I needed to abstract the existing voice command lock screen, because it semantically belongs to what the new core/system/system.py declares. I can't see how it should just continue to exist in parallel, if the platform-independent abstraction is accepted.
this would become very hard to discover.
i3wm.talon could refer to this code in a comment. Do you think the implementation in core/system should be moved?!
I am not even entirely convinced that there is any configuration for these commands that would work reliably across desktop environments.
That's why I defined the i3wm_ctx with the respective constraint. The new core/system/system_linux.py was intended to be augmented with different Talon Contexts for different desktop environments.
AI generated code for me for the class I3wmUserActions that it thought would implement the actions (same for Mac). I just didn't accept it, because I can't test it, because I'm neither a Linux user nor knowledgable in Linux. (Disclaimer: I wrote the Windows code diligently myself.)
|
Maybe I should move |
…reens on. Also made use of the `win32con` module more.
The "system" prefix is required, because the user is normally in the mindset of working with specific apps, and some widely used apps like Chrome and Firefox have their own task managers.
eb41146 to
096a3e0
Compare
See the new file
core/system/system.talonfirst for a quick overview.