Release/v0.8.2 - #72
Open
tamada wants to merge 5 commits into
Open
Conversation
- Introduced new filter options in the CLI for including and excluding build tools and files. - Updated README to reflect changes in usage syntax from `btmeister` to `btmeister-cli`. - Enhanced the `BuildToolDefs` struct to support filtering based on user-defined criteria.
There was a problem hiding this comment.
Pull Request Overview
This is a version bump release from v0.7.4 to v0.8.2, updating version badges across documentation and adding new filtering capabilities to the btmeister CLI tool.
- Updated version references from v0.7.4 to v0.8.2 in documentation and Docker configuration
- Added comprehensive filtering options for build tool definitions (includes/excludes by tool name or build file name)
- Modernized string formatting throughout the codebase using Rust's inline format syntax
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| site/content/usage.md | Updated Docker badge version reference |
| site/content/_index.md | Updated version and Docker badges |
| lib/src/lib.rs | Added Filter enum and modernized string formatting |
| lib/src/extractors/tar.rs | Updated println! formatting |
| lib/src/defs.rs | Added filtering functionality and helper functions |
| cli/src/main.rs | Modernized string formatting and integrated new defs_builder module |
| cli/src/fmt/*.rs | Updated string formatting across all formatter modules |
| cli/src/defs_builder.rs | New module implementing filter construction logic |
| cli/src/cli.rs | Added FilterOpts struct and updated CLI argument structure |
| README.md | Updated version references and CLI usage documentation |
| Dockerfile | Updated version argument |
| Cargo.toml | Updated workspace version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| fn read_file_content(f: File) -> Vec<String> { | ||
| let r = BufReader::new(f).lines() | ||
| .filter_map(|s| Some(s.unwrap())) |
There was a problem hiding this comment.
Using unwrap() on the Result from lines() will panic on I/O errors. Consider using filter_map(Result::ok) instead of filter_map(|s| Some(s.unwrap())).
Suggested change
| .filter_map(|s| Some(s.unwrap())) | |
| .filter_map(Result::ok) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#71