Remove unused dependencies and dead code - #16
Merged
Merged
Conversation
Delete provably unused items (OverlayData, BLOCK_SHAPE_TABLE, unused serpentine coefficients) and drop stale allow(dead_code) attributes from items that are now in use. The one genuinely test-only helper (FrameBuffer::max_brightness) is narrowed to cfg_attr(not(test), allow(dead_code)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getrandom(zero references in src/tests/benches/examples; the wasm crate declares its own copy)allow(dead_code)sites — deleted unreachable items (OverlayData,BLOCK_SHAPE_TABLE, two unused serpentine constants), removed ~39 stale attributes from items that are actually in use, converted one test-only method tocfg_attr(not(test), allow(dead_code))Kept for a future API decision (each documented as reserved):
config_manager::load_config,TerminalRenderer::{reset_error_diffusion, resize_error_diffusion, stdout_mut},InputPoller::{poll_keypress, poll_mouse_event},GridRenderer::blend_with.Verification
cargo fmt --check,cargo clippy -- -D warnings(default + all-features)cargo test --lib: 752 passed;--all-features: 764 passed (= baseline)