Skip to content

Fix CLI help text defaults, ranges, and pause-style list - #18

Merged
tamirelazar merged 3 commits into
devfrom
fix/help-text
Jun 12, 2026
Merged

Fix CLI help text defaults, ranges, and pause-style list#18
tamirelazar merged 3 commits into
devfrom
fix/help-text

Conversation

@tamirelazar

Copy link
Copy Markdown
Owner

Summary

  • ~33 help strings showed constant paths instead of values (stringify! misuse): flags with default_value_t now rely on clap's automatic [default: ...] rendering; the seven Option flags (preset-merged) got literal values verified against config_defaults.rs/validation.rs
  • --pause-style help now lists all 12 accepted styles; test-only Args::default() aligned to the real default (minimal) — vignette was never user-visible
  • --decay range corrected to the enforced 0.5-0.9999; --ascii-contrast "3.0 = strong" corrected to 2.0 (= MAX_CONTRAST)

Verification

  • --help and --explain contain zero :: paths; spot-checked rendered defaults/ranges against validation rules
  • fmt, clippy -D warnings (default + all-features)
  • cargo test --lib 752 / --all-features 764 / visual regression 46 — all baseline, no test updates needed

@tamirelazar
tamirelazar merged commit f862a3f into dev Jun 12, 2026
3 checks passed
@tamirelazar
tamirelazar deleted the fix/help-text branch June 12, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant