Discoverable window-frame and chrome controls - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds F10 to cycle chrome style (reaching the previously CLI-only Expanded mode), surfaces the window-frame and chrome keybinds in the keyboard-hints overlay, and documents F10 in the README.
Changes
ControlAction::CycleChrome+RuntimeState::cycle_chrome_style()— cycles chrome style Minimal → Expanded → Fullscreen and syncsbase_chrome_state/chrome_state(makes the CLI-only Expanded mode reachable at runtime)( / )) and chrome (F10) rows added to the keyboard-hints (?) overlayTest plan
cargo test— all green (758 lib + 46 visual regression + integration)cargo clippy --all-targets -- -D warnings— cleancargo fmt --check— clean?) overlay lists both controls