Diffusion/decay art knobs: afterglow, decay-gamma, separable Gaussian, diffuse-weight - #38
Merged
Merged
Conversation
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements lever 7 (#30): four art-direction knobs on the diffusion/decay stage. All global-OFF / back-compat-neutral by default — a bare run and every existing preset are byte-identical to before; the 47 visual-regression goldens are unchanged.
Knobs (CLI + saved-config + per-preset default)
--afterglow <0..1>+--afterglow-rate <α>: EMA afterglow buffer (afterglow_lag) folded into the blended trail before downsampling, so the glow participates in white-point normalization. Luminous lingering tails. Default 0.0 (off).--decay-gamma <0.25..2.0>: value-dependent decaynew = cur·(1 − (1−factor)·(cur/peak)^(1−γ)). γ<1 lengthens faint tails without blooming cores; γ=1 delegates to the existing decay (byte-identical). Default 1.0.--diffusion-sigmarange widened 0.5–2.0 → 0.5–4.0, backed by a separable Gaussian (two 1D passes, radius ceil(3σ)) routed only when σ>2.0 — the existing 5×5/3×3 paths are untouched.--diffuse-weight <0..1>: Lague blendnew = old·(1−w) + blur·w. w=1.0 is a full-weight fast path, byte-identical to today. Default 1.0.Design notes
SimConfig; saved-config fields areOption<T>with#[serde(default)]so old TOML loads unchanged. The four new validation rules are enforced inSimConfig::validate.Verification
-D warningsclean + fmt clean.Spec: docs art-direction levers design §4–§8 (lever 7).