Added the option enableWCAGAccessibility so the user can use keyboard…#118
Open
AdGalesso wants to merge 1 commit intotanansatpal:masterfrom
Open
Added the option enableWCAGAccessibility so the user can use keyboard…#118AdGalesso wants to merge 1 commit intotanansatpal:masterfrom
AdGalesso wants to merge 1 commit intotanansatpal:masterfrom
Conversation
…s to navigate in the menu Added the aria-label and aria-invalid for screen readers
tanansatpal
requested changes
Nov 10, 2021
|
|
||
| onContainerClick(event: MouseEvent) { | ||
| if ((event.target as Element).tagName.toLowerCase() !== 'input') { | ||
| if (!this.enableWCAGAccessibility && (event.target as Element).tagName.toLowerCase() !== 'input') { |
Owner
There was a problem hiding this comment.
this is removing the earlier functionality of focusing the input if clicked on the element somewhere else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option enableWCAGAccessibility so the user can use keyboards to navigate in the menu
Added the aria-label and aria-invalid for screen readers
Hi @tanansatpal we are using this lib in a big redevelopment that requires to be WCAG compliant. Do you think we can publish those changes. Thanks