Skip to content

feat(tableplus): fix TablePlus command integration and enhance compatibility #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinugawade
Copy link

@vinugawade vinugawade commented Dec 14, 2024

Description:

This PR addresses the following issues in the @tanc/db-tools project:

  1. Fix for lando tableplus Command:
ss
lando version 
v3.23.20
  • Corrected URL generation for TablePlus GUI on macOS.
  • Added support for both /Applications/TablePlus.app and /Applications/Setapp/TablePlus.app locations.
  1. Code Cleanup:

    • Removed unused dependencies (clipboardy, fs) from dbeaver.js and sequelpro.js.
    • Updated descriptions and comments for clarity and consistency.
  2. Improved Error Handling:

    • Better messaging for unsupported database types or missing services.
    • Catch-all error handling to avoid command failures.

How to Test:

  1. Run lando tableplus in your app directory with a supported database service (mysql, mariadb, postgres).
  2. Verify that TablePlus opens with the correct database connection URL on macOS.

@vinugawade
Copy link
Author

@tanc
Fixed the lando tableplus command for macOS, ensuring it generates correct URLs and works with TablePlus paths (/Applications and Setapp). Also cleaned up unused dependencies and improved error handling.
Let me know if this looks good! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant