-
Notifications
You must be signed in to change notification settings - Fork 20
feat(scripts): add leaderboard data dump script #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fetch all leaderboard + indexing progress from GraphQL - support both mainnet and testnet endpoints - paginated fetching with retry logic (3 attempts) - output to __fixtures__/leaderboard/ with ISO timestamp 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
✅ Deploy Preview for tangle-leaderboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Claude finished @AtelyPham's task —— View job PR Review: Leaderboard Data Dump ScriptI've completed my review of the leaderboard data dump script. Overall, this is a well-structured utility script with good error handling and retry logic. Here's my detailed feedback: ✅ Code Quality & Best PracticesPositive aspects:
Suggestions for improvement:
🐛 Potential IssuesMinor issues found:
🔒 Security ConsiderationsGood security practices:
No security concerns identified - this is a read-only data fetching script with no user input or dynamic queries. ⚡ Performance ConsiderationsCurrent approach:
Potential optimizations:
📚 Documentation & MaintenanceGood:
Suggestions:
🧪 Testing ConsiderationsCurrent state: No tests, which is acceptable for a utility script. If tests were desired:
✅ Fixture Files ReviewThe generated fixture files look appropriate:
Overall AssessmentThis is a solid utility script that accomplishes its goals effectively. The code is clean, handles errors appropriately, and generates useful test fixtures. The few suggestions above are minor improvements rather than critical issues. Recommendation: ✅ Approve - Ready to merge with optional improvements for future iterations. Todo List:
|
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Supports -y/--yes for non-interactive environments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Mainnet data not included - GraphQL server ( Error: Script has retry logic (3 attempts, exponential backoff) and reduced page size (20), but server still fails. Testnet data included as proof of concept. |
|
Claude finished @AtelyPham's task —— View job PR Review: Leaderboard Data Dump ScriptI've completed my review of the leaderboard data dump script. Overall, this is a well-structured utility script with good error handling and retry logic. Here's my detailed feedback: ✅ Code Quality & Best PracticesPositive aspects:
Suggestions for improvement:
🐛 Potential IssuesMinor issues found:
🔒 Security ConsiderationsGood security practices:
No security concerns identified - this is a read-only data fetching script with no user input or dynamic queries. ⚡ Performance ConsiderationsCurrent approach:
Potential optimizations:
📚 Documentation & MaintenanceGood:
Suggestions:
🧪 Testing ConsiderationsCurrent state: No tests, which is acceptable for a utility script. If tests were desired:
✅ Fixture Files ReviewThe generated fixture files look appropriate:
Overall AssessmentThis is a solid utility script that accomplishes its goals effectively. The code is clean, handles errors appropriately, and generates useful test fixtures. The few suggestions above are minor improvements rather than critical issues. Recommendation: ✅ Approve - Ready to merge with optional improvements for future iterations. Todo List:
|
Script to backup leaderboard data from GraphQL (mainnet + testnet).
scripts/dumpLeaderboardData.mjs- fetches all accounts + indexing progress__fixtures__/leaderboard/with ISO timestamp🤖 Generated with Claude Code