-
Notifications
You must be signed in to change notification settings - Fork 245
[wip] Duktape optimization #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hjanetzek
wants to merge
49
commits into
scene-refactor-base
Choose a base branch
from
duktape-optimization
base: scene-refactor-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144a38e to
33a93ef
Compare
e60e7d6 to
e6c127a
Compare
33a93ef to
76f5a9f
Compare
e6c127a to
d7e6a29
Compare
8c1127b to
801cb56
Compare
d7e6a29 to
18935b4
Compare
801cb56 to
0e012e4
Compare
18935b4 to
988370e
Compare
- enqueue async calls on single thread
- MapController is calling dispose, so it must be alive here
988370e to
3c2d3d5
Compare
- no allocations for lots of temporary JSValue - less virtual calls - a word with only one google result! Yay!
- cache ptr to Tangram::Value for the last requested properties
- needed to prevent their object to be garbage collected - instead of storing in feature object
- checking for defaultTexture is faster than checking rules - reduce scope of auto& q = _line[i+1];
0e012e4 to
31ac99b
Compare
Member
Author
|
Just running all filter and styling functions alone Duktape is 5 times faster than JScore now: |
a3db120 to
fc5cad1
Compare
fc5cad1 to
70c0ac8
Compare
70c0ac8 to
e52adb3
Compare
85bc680 to
7c550ee
Compare
8e4bf77 to
99e3511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.