This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Fix two small issues. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows to configure the `Class.getName()` result, typically in order to obfuscate and/or reduce code size.
… on JS value. As opposed to using `"" + x`, which is only valid for string concatenation. In most cases it makes no difference. The difference can only be observed for `symbol`s.
tanishiking
approved these changes
Apr 17, 2024
| @@ -226,11 +226,6 @@ lazy val `scalajs-test-suite` = project | |||
|
|
|||
| lazy val IgnoredTestNames: Set[String] = { | |||
| Set( | |||
| // javaLangClassGetNameRenamedThroughSemantics failed: org.junit.ComparisonFailure: | |||
| // expected:<[renamed.test.]Class> but was:<[org.scalajs.testsuite.compiler.ReflectionTest$RenamedTest]Class> | |||
| "org.scalajs.testsuite.compiler.ReflectionTest", | |||
There was a problem hiding this comment.
[note]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely #105 and #106.