This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Flat codegen with infrastructure for adaptions. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't introduce RETURN; it is implicit for the whole expression. * Don't flatten Blocks; they don't generate BLOCK's anymore so their codegen is already flat.
This will make it easier to insert adaptations afterward. More importantly, it makes the codegen linear. When concatenating lists it can quickly become exponential in the size of a method.
sjrd
force-pushed
the
flat-codegen-with-adapt
branch
from
1ccf6ff to
796ec22
Compare
`genTree` now takes an `expectedType`. It computes what kind of tree it actually generates. If the generated type is such that the wasm type is not a subtype of the expected wasm type, `genAdapt` makes the adaptation. Currently, the only real adaptation that we need is from any type to `NoType` (i.e., `void`). Indeed, in the IR type system, `void` is a supertype of all types, but it is not the case in the wasm type system.
It is a nullable reference of the `undef` struct.
sjrd
force-pushed
the
flat-codegen-with-adapt
branch
from
796ec22 to
ddcfa62
Compare
tanishiking
approved these changes
Mar 11, 2024
| } | ||
|
|
||
| private def transformAssign(t: IRTrees.Assign): List[WasmInstr] = { | ||
| val wasmRHS = transformTree(t.rhs) | ||
| private def genAdapt(generatedType: IRTypes.Type, expectedType: IRTypes.Type): Unit = { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because based on #10, which should be merged before this one.