This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Getting closer to the Scala.js linker architecture. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all the knowledge of the IR from `wasm4s.Names`. The name `VarGen` is the same as the corresponding logic in the JS backend.
Wasm does not have such a thing, even in the text format.
We extract the Wasm-only parts into new classes `ModuleBuilder` and `FunctionBuilder`. The parts that interact with the IR and/or contain "decision-making" related to our back-end stay in `WasmContext` and `WasmFunctionContext` and are moved to `ir2wasm`. We make `WasmModule` fully immutable in the process, since the mutable aspects are moved to `ModuleBuilder`.
Use `VarGen.genTypeName` instead.
tanishiking
approved these changes
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.